Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configurable master alias #156

Merged

Conversation

aleksdikanski
Copy link

This fixes #127 and will allow the master alias name to be selected by a command line option sls deploy --masterAlias <masterAlias>. The master alias name will be exported in the base stack as value and will be used upon removal of the stack.

@Enase
Copy link
Contributor

Enase commented May 10, 2019

Could you update README.md?

@aleksdikanski aleksdikanski force-pushed the feature/configurable_master_alias branch from 7d359aa to 94ae91a Compare May 10, 2019 20:33
@HyperBrain
Copy link
Member

It looks like this first has to be rebased onto the current master. There are a lot more differences than just the "allow master alias ..." ;-)

@aleksdikanski aleksdikanski force-pushed the feature/configurable_master_alias branch from 94ae91a to be44b03 Compare May 12, 2019 13:03
@HyperBrain
Copy link
Member

It looks like there are files with conflict markers committed in there. Can you have a look?

@aleksdikanski aleksdikanski force-pushed the feature/configurable_master_alias branch 2 times, most recently from a4f4524 to f14445c Compare May 12, 2019 15:53
@aleksdikanski
Copy link
Author

@HyperBrain Sorry for the rebase mess :) Should all be fixed now.

@aleksdikanski aleksdikanski force-pushed the feature/configurable_master_alias branch from 01280e2 to 174e9d8 Compare May 13, 2019 16:09
Update README with configurable master alias usage

Remove Merge markers
@aleksdikanski aleksdikanski force-pushed the feature/configurable_master_alias branch from 174e9d8 to 664e746 Compare May 22, 2019 20:36
@Enase Enase merged commit 709bbf8 into serverless-heaven:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master CF stack name convention
3 participants